-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Update README.md #2807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update README.md #2807
Conversation
remove unnecessary <> from Enterprise Edition link and fix pull request URL
@rahul-srivastava-codes is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughREADME.md updated: adjusted a pull request link from /pull to /pulls in Contributing, and removed angle brackets around an Enterprise Edition license URL without changing its destination. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
63-63
: Fixed PR link — consider pointing to the “new PR” flow for convenienceGood correction from /pull to /pulls. Optionally, link to the compare page so contributors land directly on the “Open a pull request” flow.
-- Make a [pull request](https://github.com/dubinc/dub/pulls) to add new features/make quality-of-life improvements/fix bugs. +- Make a [pull request](https://github.com/dubinc/dub/compare) to add new features/make quality-of-life improvements/fix bugs.
75-75
: Angle brackets removed — nit: escape parentheses in the URL for maximum Markdown compatibilityGitHub renders nested parentheses fine, but some renderers choke on them. Percent-encode the (ee) segment to be fully robust.
-... (["/ee" Enterprise Edition](https://github.com/dubinc/dub/tree/ee/apps/web/app/(ee))) ... +... (["/ee" Enterprise Edition](https://github.com/dubinc/dub/tree/ee/apps/web/app/%28ee%29)) ...
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md
(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-05-29T04:49:42.842Z
Learnt from: devkiran
PR: dubinc/dub#2448
File: packages/email/src/templates/partner-program-summary.tsx:254-254
Timestamp: 2025-05-29T04:49:42.842Z
Learning: In the Dub codebase, it's acceptable to keep `partners.dub.co` hardcoded rather than making it configurable for different environments.
Applied to files:
README.md
remove unnecessary <> from Enterprise Edition link and fix pull request URL
Summary by CodeRabbit