Merge pull request #468 from duckdb/jwills_make_secret_construction_t…

…hreadsafe

Move the secret creation to a connection-level operation instead of a cursor-level operation

dbt/adapters/duckdb/environments/__init__.py

@@ -179,6 +179,10 @@ def initialize_db(
                     conn.execute(f"install {ext.name} from {ext.repo}")
                     conn.load_extension(ext.name)
 
+        # Create/update secrets on the database
+        for sql in creds.secrets_sql():
+            conn.execute(sql)
+
         # Attach any fsspec filesystems on the database
         if creds.filesystems:
             import fsspec
@@ -216,9 +220,6 @@ def initialize_cursor(
                 # to the correct type
                 cursor.execute(f"SET {key} = '{value}'")
 
-        for sql in creds.secrets_sql():
-            cursor.execute(sql)
-
         # update cursor if something is lost in the copy
         # of the parent connection
         if plugins:

tests/unit/test_duckdb_adapter.py

@@ -115,7 +115,7 @@ def test_create_secret(self, connector):
         DuckDBConnectionManager.close_all_connections()
         connection = self.adapter.acquire_connection("dummy")
         assert connection.handle
-        connection.handle._cursor._cursor.execute.assert_called_with(
+        connection._handle._env.conn.execute.assert_called_with(
 """CREATE OR REPLACE SECRET _dbt_secret_1 (
     type s3,
     key_id 'abc',