Skip to content

Add allow_asterisks_in_http_paths setting, that default to false, so … #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlopi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add allow_asterisks_in_http_paths setting, that default to false, so … #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/httpfs_extension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ static void LoadInternal(ExtensionLoader &loader) {
"http_keep_alive",
"Keep alive connections. Setting this to false can help when running into connection failures",
LogicalType::BOOLEAN, Value(true));
config.AddExtensionOption("allow_asterisks_in_http_paths", "Allow '*' character in URLs users can query",
LogicalType::BOOLEAN, Value(false));
config.AddExtensionOption("enable_curl_server_cert_verification",
"Enable server side certificate verification for CURL backend.", LogicalType::BOOLEAN,
Value(true));
Expand Down
8 changes: 8 additions & 0 deletions src/include/httpfs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,14 @@ class HTTPFileSystem : public FileSystem {
static bool TryParseLastModifiedTime(const string &timestamp, timestamp_t &result);

vector<OpenFileInfo> Glob(const string &path, FileOpener *opener = nullptr) override {
if (path.find('*') != std::string::npos && opener) {
Value setting_val;
if (FileOpener::TryGetCurrentSetting(opener, "allow_asterisks_in_http_paths", setting_val) &&
!setting_val.GetValue<bool>()) {
throw InvalidInputException("Globs (`*`) for generic HTTP file is are not supported.\nConsider `SET "
"allow_asterisks_in_http_paths = true;` to allow this behaviour");
}
}
return {path}; // FIXME
}

Expand Down
28 changes: 28 additions & 0 deletions test/sql/httpfs/globbing.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# name: test/sql/httpfs/globbing.test
# description: Ensure the HuggingFace filesystem works as expected
# group: [httpfs]

require parquet

require httpfs

statement error
select parse_path(filename), size, part, date from read_parquet('https://raw.githubusercontent.com/duckdb/duckdb/main/data/parquet-testing/hive-partitioning/simple/*/*/test.parquet') order by filename;
----
Invalid Input Error: Globs (`*`) for generic HTTP file is are not supported.

statement ok
SET allow_asterisks_in_http_paths = true;

statement error
select parse_path(filename), size, part, date from read_parquet('https://raw.githubusercontent.com/duckdb/duckdb/main/data/parquet-testing/hive-partitioning/simple/*/*/test.parquet') order by filename;
----
HTTP Error: Unable to connect to URL

statement ok
SET allow_asterisks_in_http_paths = false;

statement error
select parse_path(filename), size, part, date from read_parquet('https://raw.githubusercontent.com/duckdb/duckdb/main/data/parquet-testing/hive-partitioning/simple/*/*/test.parquet') order by filename;
----
Invalid Input Error: Globs (`*`) for generic HTTP file is are not supported.
Loading