Skip to content

Rename disable_global_s3_configuration to enable_global_s3_configuration #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlopi merged 1 commit into from
Jan 13, 2026
Merged

Rename disable_global_s3_configuration to enable_global_s3_configuration #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/httpfs_extension.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ static void LoadInternal(ExtensionLoader &loader) {
};
config.AddExtensionOption("httpfs_client_implementation", "Select which is the HTTPUtil implementation to be used",
LogicalType::VARCHAR, "default", callback_httpfs_client_implementation);
config.AddExtensionOption("disable_global_s3_configuration",
config.AddExtensionOption("enable_global_s3_configuration",
"Automatically fetch AWS credentials from environment variables.", LogicalType::BOOLEAN,
Value::BOOLEAN(true));

Expand Down
2 changes: 1 addition & 1 deletion src/s3fs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1382,7 +1382,7 @@ S3KeyValueReader::S3KeyValueReader(FileOpener &opener_p, optional_ptr<FileOpener
idx_t secret_types_len)
: reader(opener_p, info, secret_types, secret_types_len) {
Value use_env_vars_for_secret_info_setting;
reader.TryGetSecretKeyOrSetting("disable_global_s3_configuration", "disable_global_s3_configuration",
reader.TryGetSecretKeyOrSetting("enable_global_s3_configuration", "enable_global_s3_configuration",
use_env_vars_for_secret_info_setting);
use_env_variables_for_secret_settings = use_env_vars_for_secret_info_setting.GetValue<bool>();
}
Expand Down
2 changes: 1 addition & 1 deletion test/sql/test_read_public_bucket.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ SELECT * FROM read_parquet('s3://coiled-datasets/timeseries/20-years/parquet/par

# default to not using globally scoped settings for secrets
statement ok
set disable_global_s3_configuration=false;
set enable_global_s3_configuration=false;

statement ok
SELECT * FROM read_parquet('s3://coiled-datasets/timeseries/20-years/parquet/part.0.parquet') LIMIT 5;
Loading