Skip to content

Disable non-direct insert column orderings #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2025
Merged

Disable non-direct insert column orderings #445

merged 2 commits into from
Sep 5, 2025

Conversation

Tishj
Copy link
Collaborator

@Tishj Tishj commented Sep 3, 2025

This PR applies a temporary bandaid for #444

If a column is missing or not given in the right order, a NotImplementedException is thrown.

Tmonster
Tmonster approved these changes Sep 4, 2025
View reviewed changes
Copy link
Collaborator

@Tmonster Tmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe we can also get a test for this?
I understand it requires more CI though, so maybe a test can come later

@Tmonster Tmonster merged commit b6f589c into duckdb:main Sep 5, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tmonster Tmonster Tmonster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tishj @Tmonster