Skip to content

Keep track of known fake schemas #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 10, 2025
Merged

Keep track of known fake schemas #459

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
992bb3b
only request a schema existence once per transaction
Tmonster Sep 9, 2025
193542a
PR comments
Tmonster Sep 9, 2025
1c7c077
PR comment
Tmonster Sep 10, 2025
1fec1cc
Merge remote-tracking branch 'upstream/main' into keep_track_of_known…
Tmonster Sep 10, 2025
61dad9c
fix and a test
Tmonster Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/include/storage/irc_transaction.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ class IRCTransaction : public Transaction {
unordered_set<const ICTableEntry *> dirty_tables;
unordered_set<const ICTableEntry *> deleted_tables;
case_insensitive_set_t created_secrets;

case_insensitive_set_t looked_up_entries;
};

} // namespace duckdb
14 changes: 14 additions & 0 deletions src/storage/irc_schema_set.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,26 @@ namespace duckdb {
IRCSchemaSet::IRCSchemaSet(Catalog &catalog) : catalog(catalog) {
}

// we are sure the schema does not exist, we performed the head request and got a 404 response.
static bool SchemaDoesNotExist(case_insensitive_set_t &known_non_existent_schemas, const string &name) {
return known_non_existent_schemas.find(name) != known_non_existent_schemas.end();
}

optional_ptr<CatalogEntry> IRCSchemaSet::GetEntry(ClientContext &context, const string &name,
OnEntryNotFound if_not_found) {
lock_guard<mutex> l(entry_lock);
auto &ic_catalog = catalog.Cast<IRCatalog>();

auto &irc_transaction = IRCTransaction::Get(context, catalog);

auto verify_existence = irc_transaction.looked_up_entries.insert(name).second;
auto entry = entries.find(name);
if (entry != entries.end()) {
return entry->second.get();
}
if (!verify_existence) {
return nullptr;
}
if (entry == entries.end()) {
CreateSchemaInfo info;
if (!IRCAPI::VerifySchemaExistence(context, ic_catalog, name)) {
Expand Down
Loading