Move avro in extension_config #462
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quality of life improvement.
Basically, when you build iceberg now and try to run release or debug, there is an attempt to load the avro extension from
~.duckdb/extensions/hash/osx_arm64/avro.duckdb_extension
, and there is no guarantee it is always there. This is caused because first iceberg is loaded, which in turn tries to load avro using the extension loader. Since avro is not yet loaded, the default location is tried which is the one I just mentioned.To fix this, we move the avro extension to be before the iceberg config, which means it will be loaded before iceberg, so when iceberg tries to load avro, we don't look in the
~.duckdb
location.