Fix Cloud tests. Modify what responses to /namespaces return false
#481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS requests would log every request as a GET request. This was incorrect and has now been fixed.
Also, when running
VerifyNamespaceExistence, we would only return false if the response was 404. Via cloud testing I have found that some other catalogs return other responses. To avoid surfacing unnecessary http response codes to users, I have decided to expand the scope of what responses merit a logical "This table does not exist" response.I have noticed in particular with the Glue catalog that responses are inconsistent with what the iceberg rests api spec defined.
Also added
set ignore_error_messagesfor a lot more of the cloud tests.