Skip to content

Conversation

Tishj
Copy link
Collaborator

@Tishj Tishj commented Sep 16, 2025

Added a test where iceberg_to_ducklake is used on the entire generated catalog of tests, and (pretty much) all tables are compared against each other:

query I rowsort expected_res
select * from my_datalake.default.${table_name}
----

query I rowsort expected_res
select * from my_ducklake.default.${table_name}
----

@Tishj Tishj changed the base branch from main to v1.4-andium September 16, 2025 12:49
@Tishj
Copy link
Collaborator Author

Tishj commented Sep 16, 2025

@Tmonster this is refusing to run any CI, do you know what's going on?

@Tmonster
Copy link
Collaborator

@Tishj maybe change the base branch to main? We can delete v1.4-andium for now

@Tishj
Copy link
Collaborator Author

Tishj commented Sep 16, 2025

We shouldn't, v1.4-andium is where v1.4.0 should be built from, and we will definitely need to keep v1.4-andium around for the LTS, main is where v1.5 development should go

@carlopi
Copy link
Contributor

carlopi commented Sep 16, 2025

I would keep v1.4-andium around, we can chat tomorrow.

I think proper path is:

  1. merge main: don't publish for wasm #477
  2. modify this PR to point to main AND at the same time to build vs v1.4.0 (both submodule AND MainDistribution)

@carlopi
Copy link
Contributor

carlopi commented Sep 16, 2025

v1.4-andium is at the moment left behind, and probably should not, but that we can fix tomorrow.

@Tmonster
Copy link
Collaborator

Ok, I have cancelled the last bit of running CI for now, CI here should run eventually, but potentially is clogged by all other CI on the rest of the extensions. @c-herrewijn does every extension right now have a PR up to bump submodules? I can imagine that is clogging a lot of stuff no?

@Tishj
Copy link
Collaborator Author

Tishj commented Sep 16, 2025

I think it would show the runs even if they haven't started, but this doesn't have any CI queued even

@Tishj Tishj changed the base branch from v1.4-andium to main September 16, 2025 14:52
@Tmonster
Copy link
Collaborator

Tmonster commented Sep 16, 2025

@Tishj I imagine CI passes for you locally? If so, and the builds pass, then I'm fine with merging so we can get this in quick. We can fix the tests in the next PR.
Tomorrow we can also update the v1.4 and main branches

edit: Nvm, see you just changed it. No worries then

@guillesd
Copy link

guillesd commented Sep 17, 2025

@Tishj ping me when you have this! I need to add it to the release post!

@Tishj
Copy link
Collaborator Author

Tishj commented Sep 17, 2025

Sure, my CI got canceled for some reason though?

@Tishj Tishj force-pushed the iceberg_to_ducklake_tests branch from 9afae45 to 6f8e534 Compare September 17, 2025 09:01
@Tishj Tishj changed the base branch from main to v1.4-andium September 17, 2025 09:01
@Tishj
Copy link
Collaborator Author

Tishj commented Sep 17, 2025

Btw this test is very slow, like, several minutes on a release build
I'm not sure if the pipeline here (or extension-ci-tools) is built to treat test_slow differently, like core does
If it doesn't, this is going to increase CI time substantially.

@Tishj Tishj marked this pull request as draft September 17, 2025 09:10
@Tishj Tishj marked this pull request as ready for review September 17, 2025 09:11
@Tishj Tishj changed the base branch from v1.4-andium to main September 17, 2025 09:21
@Tishj Tishj marked this pull request as draft September 17, 2025 09:21
@Tishj Tishj marked this pull request as ready for review September 17, 2025 09:22
@carlopi carlopi requested a review from Tmonster September 17, 2025 10:45
Copy link
Collaborator

@Tmonster Tmonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@Tishj Tishj merged commit 49d67e4 into duckdb:main Sep 17, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants