Fix parsing conn string with a trailing semicolon #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticlibs
changed the title
|
Thanks for the PR! Looks good - could you just merge with main so the CI can re-run? I've patched the issue with the CI in #55 |
When connection string includes a trailing comma, existing impl in Connect::ParseInputStr was doing an early exit without setting DSN value to dbc->dsn. Because of this DSN was not used and default :memory: instance was created. The problem is not OS specific, but was happening on Windows all the time because Windows ODBC Driver Manager is appending comma to the passed connection string when calling SQLDriverConnect. test_connect_odbc was extended to cover the trailing comma and also parameters overriding in connection string. Fixes: duckdb#29, duckdb#48
staticlibs
force-pushed
the
dsn_trailing_comma
branch
from
ba60a3f to
67dfadf
Compare
|
Thanks! I've rebased the branch onto main. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes the connection string parsing for cases, when such string ends with a semicolon.
When connection string includes a trailing semicolon, existing impl in
Connect::ParseInputStrwas doing an early exit without setting DSN value todbc->dsn. Because of this DSN was not used and default:memory:instance was created.The problem is not OS specific, but was happening on Windows all the time because Windows ODBC Driver Manager is appending semicolon to the passed connection string when calling
SQLDriverConnect.Testing:
test_connect_odbcwas extended to cover the trailing semicolon and also parameters overriding in connection string.Fixes: #29, #48
Edit: typo in a commit mesage:
%s/comma/semicolon/g.