Ignore UID and PWD options from Excel #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the ODBC data source is used from Excel/Power Query, additional options may be added to connection string automatically without showing them to user. It was discovered in duckdb#58 that `UID` and `PWD` options are added when user has credentials registered for this DSN in Excel. DuckDB driver does not recognize these options and currently cannot process them properly (see duckdb#59 for details). However the driver knows about possible `trusted_connection` Excel/Power Query option and ignores it successfully. It is proposed to also add `UID` and `PWD` to the existing ignore list. In the light of duckdb#60, that fixes the handling for unsupported options, this change is not strictly necessary, but it still may be better to consistently ignore all unneeded Excel/Power Query options and to not register diagnostic messages for them. Testing: existing Excel/Power Query ignore list test is extended to include new options. Fixes: duckdb#58
staticlibs
force-pushed
the
excel_uid_pwd
branch
from
d059f2e to
54b1816
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ODBC data source is used from Excel/Power Query, additional options may be added to connection string automatically without showing them to user. It was discovered in #58 that
UIDandPWDoptions are added when user has credentials registered for this DSN in Excel.DuckDB driver does not recognize these options and currently cannot process them properly (see #59 for details). However the driver knows about possible
trusted_connectionExcel/Power Query option and ignores it successfully. It is proposed to also addUIDandPWDto the existing ignore list.In the light of #60, that fixes the handling for unsupported options, this change is not strictly necessary, but it still may be better to consistently ignore all unneeded Excel/Power Query options and to not register diagnostic messages for them.
Testing: existing Excel/Power Query ignore list test is extended to include new options.
Fixes: #58