Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtab::arrow: support structs under list and array #403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajwerner
Copy link

No description provided.

@Maxxen
Copy link
Member

Maxxen commented Feb 7, 2025

Hi! Thanks for the PR. Im going to have a closer look at this on Monday and can look at resolving the conflicts then.

@ajwerner
Copy link
Author

ajwerner commented Feb 7, 2025

I actually am starting to think that all this code is not the way it should be done. Right now this is effectively duplicating code in rust that duckdb already has. In particular, I became aware a bit later about the Go: duckdb_arrow_scan used here.

That API is marked as deprecated, but in Discord @Mytherin indicated that it won't just go away without being replaced by something better: https://discord.com/channels/909674491309850675/921073327009853451/1309264012525178952

I can't imagine it makes sense to duplicate this arrow parsing in every library. Same comment goes for #405.

I feel like a reasonable approach would be to delete all this code and replace it with a call to duckdb_arrow_scan, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants