Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin duckdb and libduckdb-sys versions #438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luong-komorebi
Copy link

Context :

  • Rust considers a package version to be compatible if their leftmost greater-than-zero version is the same. This means 1.2.0 is compatible with 1.1.1. This is not "wrong" and complies well with "semver". However, minor releases of duckdb usually contains breaking changes (see changelogs at https://r.duckdb.org/news/index.html) and 1.2.0 might break 1.1.1
  • Recent changes to libduckdb-sys breaks build process on ubuntu for duckdb-rs Upgrading duckdb-rs to 1.2.0 fails linking on Ubuntu 22.04 #436. Since there was no version lock for libduckdb-sys, there are cases that even when locking duckdb-rs in downstream repos, libduckdb-sys is still upgraded to the newer and mismatched version.

Proposed changes:

  • Strictly lock version of libduckdbsys and duckdb by using Comparision Requirement. While tilde requirement can be used as well, I am not too sure if that is suitable given that every version bump in this repo usually couples duckdb-rs and libduckdb-sys

Note:

  • This should be backported to version 1.1.1 as 1.1.2 to safeguard maintainers from accidentally being bumped to 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant