Cleanup python run_fuzzer#59
Merged
Tmonster merged 6 commits intoduckdb:mainfrom Nov 14, 2025
Merged
Conversation
Tmonster
reviewed
Nov 11, 2025
Member
Tmonster
left a comment
Tmonster
left a comment
There was a problem hiding this comment.
thanks! A couple of questions
| else: | ||
| print(f"last statement {last_statement} produces no error") | ||
| if fuzzer_helper.is_internal_error(stderr) and len(expected_error) > 0: | ||
| if returncode < 0 or fuzzer_helper.is_internal_error(stderr): |
Member
There was a problem hiding this comment.
can return code be less than 0?
Member
Author
There was a problem hiding this comment.
yes, this might happen in case of a crash, see:
https://docs.python.org/3/library/subprocess.html#subprocess.CompletedProcess.returncode
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
expected_errordoes not exist in functionrun_queries_until_crash_mpsanitize_error()- it was removed in 1f4773a , but it is still useful, since the stack trace needs to be sanitized different from the actual error msg.get_internal_exception_msg()to isolate the actual internal exception error. In case of a multi statement it can be somewhere in the middle of the stderr output (e.g. preceded by 'harmless' Binder errors, and followed by the stack trace.)