New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix binary_executor.patch #1959

Open

e1arikawa wants to merge 1 commit into duckdb:main from AKABANAKK:feature/fix_binary_executor_patch

Contributor

e1arikawa commented Feb 19, 2025 •

edited

Loading

When running make apply_patches, binary_executor.patch fails.

$ make apply_patches
(find patches/duckdb/* -type f -name '*.patch' -print0 | xargs -0 cat | patch -p1 --forward -d submodules/duckdb) || true
patching file 'src/include/duckdb/common/vector_operations/binary_executor.hpp'
4 out of 7 hunks failed--saving rejects to 'src/include/duckdb/common/vector_operations/binary_executor.hpp.rej'
...

In DuckDB 1.2, binary_executor.hpp has already been modified.
Therefore, I have reduced the patch to the following:

#define DUCKDB_SMALLER_BINARY 1
...
#undef DUCKDB_SMALLER_BINARY


          fix binary_executor.patch

87caf8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet