fix(bindings): handle accessMode in runtime bindings with OPFS #1960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
During my recent usage with
duckdb-wasm
with the recent OPFS support done by @e1arikawa (Thank you for the cool work!), I encountered an issue where the file/directory handles were always created even when I opened the database with read-only options like:Summary
Going deeper, it seems we didn't handle the
accessMode
in helper functions likeprepareFileHandles
. Therefore, in this pull request, I tried to add the missing parameters to these functions as optional ones and added several test cases for open operations as such with differentaccessMode
in OPFS.