Support COMMENT ON COLUMN on views#1102
Open
redox wants to merge 2 commits into
Open
Conversation
This follows duckdb#1077 and add support for storing and loading per–view-column comments in DuckLake. Inspired by how table column tags were handled, I went for: - a new `ducklake_view_column_tag` metadata table + migration to `1.1-dev2` - a new `SET_COLUMN_COMMENT` `Entry::Alter` - here and there plumbing to make it work alongside table comments Along the way, I also found a bug where `DropViews` wouldn't expire the `ducklake_tag` with `object_id = view_id` rows. Added tests in `test/sql/comments/drop_view_expires_tags.test`. I'm not 100% sure how the `X.Y-devZ` migrations are supposed to be done, so looking for feebback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows #1077 and add support for storing and loading column comments on DuckLake views.
Inspired by how table column tags were handled, I went for:
ducklake_view_column_tagmetadata table + migration to1.1-dev2SET_COLUMN_COMMENTEntry::AlterI'm not 100% sure how the
X.Y-devZmigrations are supposed to be done, so looking for feedback.Internal Ref https://github.com/duckdblabs/altertable/issues/7