Add ducklake_target_file_size session setting#1144
Open
utay wants to merge 1 commit into
Open
Conversation
pdet
reviewed
May 12, 2026
|
|
||
| # Reset the session setting - metadata value (512MB) should now govern: everything in one file | ||
| statement ok | ||
| RESET ducklake_target_file_size |
Member
There was a problem hiding this comment.
Can you add a test where you set ducklake_target_file_size after reset?
| @@ -0,0 +1,54 @@ | |||
| # name: test/sql/insert/insert_session_target_file_size.test | |||
Member
There was a problem hiding this comment.
Can you add a test that verifies a borked string fails at set?
e.g., 'not-a-size'
Member
There was a problem hiding this comment.
Can you also validate this option is over other scopes? (e.g., per-schema, per-table)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
ducklake_target_file_sizesession-level setting that overrides thetarget_file_sizemetadata option for both inserts and compaction. This is useful when concurrent sessions need different file size targets; for example, a background compaction session targeting large files while foreground inserts use a smaller size, without either modifying the shared catalog metadata.