Remove most C++ from pgduckdb.cpp
#498
Open
+25
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
reviewed
Jan 28, 2025
| // pgduckdb_background_worker.cpp | ||
| void DuckdbInitBackgroundWorker(); | ||
|
|
||
| namespace pgduckdb { |
There was a problem hiding this comment.
If this starts containing namespace sections than the header should probably be renamed into a hpp file.
| static void | ||
| DuckdbInitGUC(void) { | ||
| void | ||
| DuckdbInitGUC() { |
There was a problem hiding this comment.
Related thought: I've been thinking we should probably move this GUC stuff to its own guc.cpp file.
JelteF
reviewed
Jan 28, 2025
Comment on lines
+13
to
+22
| void DuckdbInitGUC(); | ||
|
|
||
| // pgduckdb_hooks.cpp | ||
| void DuckdbInitHooks(); | ||
|
|
||
| // pgduckdb_node.cpp | ||
| void DuckdbInitNode(); | ||
|
|
||
| // pgduckdb_background_worker.cpp | ||
| void DuckdbInitBackgroundWorker(); |
There was a problem hiding this comment.
Why move these functions to this header instead of leaving them defined where they were?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgduckdb.hfilespgduckdb.cpp(last remaining istype_traitsfor the GUC helpers)