Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implicit % to bridge TABLESAMPLE syntax #559

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add implicit % to bridge TABLESAMPLE syntax #559

wants to merge 5 commits into from

Conversation

nbiscaro
Copy link

@nbiscaro nbiscaro commented Jan 26, 2025 •
edited
Loading

Implements #558.

Bridge syntax differences in TABLESAMPLE by adding implicit %.

@nbiscaro nbiscaro mentioned this pull request Jan 26, 2025
Open
@nbiscaro nbiscaro changed the title Add implicit % to bridge syntax Add implicit % to bridge TABLESAMPLE syntax Jan 26, 2025
JelteF
JelteF requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This needs some tests though.

@nbiscaro nbiscaro force-pushed the bridge-tablesample branch 2 times, most recently from 76966b8 to e216177 Compare January 30, 2025 23:56
@JelteF JelteF added this to the 0.4.0 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelteF JelteF JelteF requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nbiscaro @JelteF