Skip to content

update tds v3 -> v4#1462

Closed
ladamski wants to merge 1 commit intodevelopfrom
la/tds-v4
Closed

update tds v3 -> v4#1462
ladamski wants to merge 1 commit intodevelopfrom
la/tds-v4

Conversation

@ladamski
Copy link
Contributor

@ladamski ladamski commented Oct 20, 2022 •
edited
Loading

Reviewer: @jdorweiler

Description:

https://app.asana.com/0/1171671347221384/1203125805176391/f

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@ladamski ladamski closed this Dec 15, 2022
@ladamski ladamski deleted the la/tds-v4 branch December 15, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ladamski