Skip to content

Tracker allowlist wildcard tests #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sammacbeth wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Tracker allowlist wildcard tests #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a80fd8
Add tests for wildcard rule match behavior
sammacbeth Feb 16, 2024
9670fd0
Fix test result
sammacbeth Feb 16, 2024
af0b26b
Reverse tests to take allowlist rule as regex
sammacbeth Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tracker-radar-tests/TR-domain-matching/tracker_allowlist_matching_tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,5 +150,23 @@
"site": "https://testsite.com",
"request": "http://a.b.c.videos.allowlist-tracker-2.com/a.js",
"isAllowlisted": true
},
{
"description": "* alone does not match wildcard",
"site": "https://testsite.com",
"request": "https://allowlist-tracker-2.com/anything/wildcard.js",
"isAllowlisted": false
},
{
"description": "* works as a regex operator",
"site": "https://testsite.com",
"request": "https://allowlist-tracker-2.com/////wildcard.js",
"isAllowlisted": true
},
{
"description": "Regex .* is treated as a wildcard",
"site": "https://testsite.com",
"request": "https://allowlist-tracker-2.com/anything/wildcard2.js",
"isAllowlisted": true
}
]
10 changes: 10 additions & 0 deletions tracker-radar-tests/TR-domain-matching/tracker_allowlist_reference.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,16 @@
"rule": "allowlist-tracker-2.com/login.js",
"domains": ["<all>"],
"reason": "match single resource on all sites"
},
{
"rule": "allowlist-tracker-2.com/*/wildcard.js",
"domains": ["<all>"],
"reason": "wildcard rule"
},
{
"rule": "allowlist-tracker-2.com/.*/wildcard2.js",
"domains": ["<all>"],
"reason": "wildcard rule with regex syntax"
}
]
},
Expand Down