Add reference tests for the Request Blocklist feature#152
Merged
kzar merged 1 commit intoduckduckgo:mainfrom Oct 18, 2025
Merged
Add reference tests for the Request Blocklist feature#152kzar merged 1 commit intoduckduckgo:mainfrom
kzar merged 1 commit intoduckduckgo:mainfrom
Conversation
kzar
commented
Oct 16, 2025
| "exceptPlatforms": [] | ||
| }, | ||
| { | ||
| "name": "matching rule, case considered", |
Collaborator
Author
There was a problem hiding this comment.
@dharb So far I went with case-sensitive matching. My thinking there is that case-sensitive matching is both more efficient + more powerful. But that is at odds with the Tracker Allowlist which I think goes with case-insensitive matching. I'm open to either, WDYT?
Contributor
There was a problem hiding this comment.
@kzar I don't think I even realized that the tracker allowlist isn't case sensitive. My take would be to go with case-sensitive matching here and let's just make sure to document it well.
kzar
force-pushed
the
request-blocklist
branch
from
348700f to
91e2239
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.