Remove windows-browser from exceptPlatforms in storage-clearing tests#157
Open
Remove windows-browser from exceptPlatforms in storage-clearing tests#157
Conversation
Enable storage-clearing tests for the windows-browser platform by removing it from the exceptPlatforms lists where cookies set by third-party iframes are expected not to be removed. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana task: https://app.asana.com/1/137249556945/project/72649045549333/task/1211398846337324?focus=true
Summary
windows-browserfrom theexceptPlatformsarrays in 4 storage-clearing test cases that should work after the changes in https://app.asana.com/1/137249556945/project/1210132634900450/task/1205150004869238?focus=truedevelopNote
Low Risk
Test-data-only change that adjusts platform exclusions; risk is limited to potentially exposing previously masked Windows test failures.
Overview
Updates
storage-clearing/tests.jsonto stop excludingwindows-browserfrom four fireproofing-related cookie-clearing test cases (subdomain/dot-notation scenarios), so Windows is expected to follow the same behavior as other supported platforms.No production logic changes; this only adjusts cross-platform test expectations.
Written by Cursor Bugbot for commit 7ff24f9. This will update automatically on new commits. Configure here.