Conversation
|
@marcosholgado I think we want to update the README too, with:
|
Yup! Done |
|
Okay this LGMT unless we:
|
kdzwinel
left a comment
There was a problem hiding this comment.
Yeah, now that we have those new params we should add some tests that actually use them. This can be a follow up PR though.
| {"name": "blockedTrackers", "value": "bad.tracker.test,tracking.test"}, | ||
| {"name": "surrogates", "value": "surrogate.domain.test"} | ||
| ], | ||
| "urlParametersRemoved": "0", |
There was a problem hiding this comment.
Readme says that those were meant to be booleans?
There was a problem hiding this comment.
Fair point :D Actually it depends on how you define a boolean, is it true/false or 1/0 or is it the same thing? The reporting failed because we were using true/false and the expectation was 1/0 so I guess is not really a boolean but a value of 1 or 0.
I think 1/0 is confusing though and we are using booleans in other places (i.e. true/false for wasUpgraded) so I find it weird that these few parameters need 1/0.
https://app.asana.com/0/0/1203012116406182/f
This PR adds the missing parameters for autoconsent and urlParameterRemoved to the broken sites test