Skip to content

Fix race condition in team duel match ending causing players to get stuck in duel state #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from
Closed

Fix race condition in team duel match ending causing players to get stuck in duel state #236

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ee2fed
Initial plan
Copilot Jan 14, 2026
5f48e4e
Fix team duel race condition by marking matches as finished immediately
Copilot Jan 14, 2026
88bef27
Improve comments based on code review feedback
Copilot Jan 14, 2026
1b79636
Fix: Move setFinished() inside handler methods to allow proper execution
Copilot Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions duels-plugin/src/main/java/com/meteordevelopments/duels/duel/DuelManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,14 @@ public DuelManager(final DuelsPlugin plugin) {
}

public void handleMatchEnd(DuelMatch match, ArenaImpl arena, Player loser, Location deadLocation, Player winner) {
// Safety check: Don't process if match is already finished (prevents race condition where multiple death events trigger concurrent match ending)
if (match.isFinished()) {
return;
}

// Mark match as finished immediately to prevent re-entry from concurrent death events
match.setFinished();

DuelsPlugin.getMorePaperLib().scheduling().regionSpecificScheduler(arena.first().getLocation()).runDelayed(() -> {
if (arena.size() == 0) {
match.getAllPlayers().forEach(matchPlayer -> {
Expand Down Expand Up @@ -208,6 +216,14 @@ public void handleMatchEnd(DuelMatch match, ArenaImpl arena, Player loser, Locat
}

public void handleTeamMatchEnd(TeamDuelMatch match, ArenaImpl arena, Location deadLocation, TeamDuelMatch.Team winningTeam) {
// Safety check: Don't process if team match is already finished (prevents race condition where multiple team member deaths trigger concurrent match ending)
if (match.isFinished()) {
return;
}

// Mark match as finished immediately to prevent re-entry from concurrent team member deaths
match.setFinished();

DuelsPlugin.getMorePaperLib().scheduling().regionSpecificScheduler(deadLocation).runDelayed(() -> {
if (config.isSpawnFirework()) {
DuelsPlugin.getMorePaperLib().scheduling().regionSpecificScheduler(deadLocation).run(() -> {
Expand Down