Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new tokens to prices - arb, bnb, ftm, op [READY] #5538

Merged
merged 85 commits into from
Mar 11, 2024

Conversation

RantumBits
Copy link
Contributor

Thank you for contributing to Spellbook!

Thank you for taking the time to submit code in Spellbook. A few things to consider:

  • If you are a first-time contributor, please sign the CLA by copy & pasting exactly what the bot mentions in PR comment
  • Refer to docs section below to answer questions
  • Dune team will review submitted PRs as soon as possible

Spellbook sub-projects

To prepare for Spellbook to scale in size, Dune team has started to pilot sub-projects:

  • For a quick overview, see the GH discussion on the topic
    • Please ask questions and continue the conversation there
  • The first spell lineage to move: tokens.erc20 and all upstream spells which help build it
    • Note: Please navigate to tokens root directory to find tokens objects

Spellbook contribution docs

The docs directory has been implemented to answer as many questions as possible. Please take the time to reference each .md file within this directory to understand how to efficiently contribute & why the repo is designed as it is 🪄

Example questions to be answered:

Please navigate through the docs directory to find as much info as you can.

Note: happy to take PRs to improve the docs, let us know 🤝

RantumBits and others added 30 commits June 1, 2021 14:07
@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8206882012 approved.

@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8206881849 approved.

@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8206882016 approved.

@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8206908430 approved.

@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8206908782 approved.

@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8206908778 approved.

@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8207077538 approved.

@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8207077884 approved.

@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8207077885 approved.

@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8207089729 approved.

@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8207089884 approved.

@dune-eng
Copy link

dune-eng commented Mar 8, 2024

Workflow run id 8207089885 approved.

@RantumBits RantumBits changed the title add new tokens to prices - arb, bnb, ftm, op add new tokens to prices - arb, bnb, ftm, op [READY] Mar 8, 2024
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @RantumBits

@jeff-dude jeff-dude self-assigned this Mar 11, 2024
@jeff-dude jeff-dude merged commit f5dcc52 into duneanalytics:main Mar 11, 2024
2 of 4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
@RantumBits RantumBits deleted the new-tokens-c branch August 9, 2024 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants