-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zeroex - v2 macro updates #7460
Conversation
this is finally ready @Hosuke - runs relatively quickly and properly picks up bundled txs. also adds some new chains. lmk if you have questions |
@Hosuke I'm adding additional chains via the same macro. There was a database connection error on last run |
all set again @Hosuke, now with all chains moved to this macro |
thank you for getting these back into a final reviewable state 🙏 we should take time to query the CI tables in-depth, to ensure we're happy this time around. |
Yes I am happy with the output. There are some transactions with value mismatches compared to old settler model. This is purposeful and corrects a previous issue with some trades having wrong maker values. These now match internal data. Comparison here: https://dune.com/queries/4742039?sidebar=none I took a look at the top trades by USD Volume and the output looks good there as well. These can be viewed here: https://dune.com/queries/4742159
|
thank you for the additional context and validation. i pushed a few minor commits to filter a bit more on incremental runs & then run tables downstream to ensure pipeline is all good still. let me know if any of the incremental filters break anything here 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data in dex_aggregator.trades
looks good to me after running here in CI. i'm good with the code now. thanks again for taking the time to build this and test thoroughly
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2025 Dune Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Description:
quick links for more information: