Skip to content

update enrich_balancer_v3_dex_trades#7489

Merged
jeff-dude merged 6 commits intoduneanalytics:mainfrom
viniabussafi:4626to20
Jan 22, 2025
Merged

update enrich_balancer_v3_dex_trades#7489
jeff-dude merged 6 commits intoduneanalytics:mainfrom
viniabussafi:4626to20

Conversation

@viniabussafi
Copy link
Copy Markdown
Contributor

@viniabussafi viniabussafi commented Jan 17, 2025

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

This PR works to rebuild the same logic used on #7467, but reverted on #7478. The difference is that the changes are now made further downstream


quick links for more information:

@viniabussafi viniabussafi marked this pull request as ready for review January 20, 2025 10:57
@github-actions github-actions Bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 20, 2025
Copy link
Copy Markdown
Contributor

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.✅
Thank you @viniabussafi

@Hosuke Hosuke added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Jan 21, 2025
@jeff-dude jeff-dude self-assigned this Jan 21, 2025
@jeff-dude jeff-dude merged commit 83370f8 into duneanalytics:main Jan 22, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dbt: dex covers the DEX dbt subproject ready-for-merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants