add fasol bot #7492
Open
add fasol bot #7492
+255
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
github-actions
bot
added
ready-for-review
- Extract prices.usd and solana.transactions into separate filtered CTEs - Select only necessary columns in CTEs - Move incremental filters to CTE level - Simplify JOIN conditions in botTrades CTE
Hosuke
approved these changes
Jan 19, 2025
| blockchain: solana | ||
| sector: dex | ||
| project: fasol | ||
| contributors: whale_hunter |
There was a problem hiding this comment.
Maybe you can add your credit:
Suggested change
| contributors: whale_hunter | |
| contributors: whale_hunter, clizzard7 |
Hosuke
added
ready-for-final-review
and removed
ready-for-review
jeff-dude
added
in review
|
i think we should consider this one similar to photon, even though it finished in CI (though it took almost the full 90m) |
|
@jeff-dude we had a discussion on how to improve performance (next to the changes @Hosuke made here) and decided to split fee payments and trades into separate spellbooks. hope this improves it, lmk if you have other ideas on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add trades, schema and seed for Fasol Trading Bot (SOLANA)
Dune dashboard TBD
https://x.com/fasol_robot