-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Event Models for GMX v2 #7511
Update Event Models for GMX v2 #7511
Conversation
thank you for initiating the PR. let's talk we don't use this function much in spellbook at this time. mostly due to the exact scenario you are running into, and it can lead to prod failures on our cluster the same as it would on a view query execution. if it's an isolated dbt lineage of models, it's usually fine, as next run can resolve itself and it doesn't block other models. ideally though, we would still keep that function out of spellbook if possible. what do you think of this approach? in practice, it would be:
|
"Create a spell view that reads from a materialized view on the GMX team account."
I don't want to remove these dbt models |
the view will fail at query execution time on the app, saying table doesn't exist. it will signal to you and team that you need to rebuild your mat view.
syntax: source file: spellbook/sources/_datasets/dune/sources.yml Lines 1 to 6 in c342d7e
should be all you need |
Thank you for your help. I will do it this way and tag you when it's ready for review. |
@jeff-dude could you help me, please? where should I place "dune" and where to locate team username "gmx-io"? |
I have to compile this name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like my commit worked. not sure if it was single quotes or what, but this should be proper formatting for mat views 🙏
our dbt source macro compiles to include double quotes around source database/schema/table by default, which i think helps here especially with the gmx-io
team name having a dash in there
Thank you for your help. I have reviewed your commit. You can merge it if all is fine for you too. |
Thank you for contributing to Spellbook 🪄
Please open the PR in draft and mark as ready when you want to request a review.
Description:
This PR modifies the
*_withdrawal_created
dbt models to include three new columns:Additionally, we changed the materialization of
gmx_v2_arbitrum_erc20
andgmx_v2_avalanche_c_erc20
from views to tables.quick links for more information: