Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUX-839 Initiate sophon chain #7541

Merged
merged 22 commits into from
Feb 21, 2025

Conversation

Hosuke
Copy link
Collaborator

@Hosuke Hosuke commented Jan 24, 2025

No description provided.

@github-actions github-actions bot marked this pull request as draft January 24, 2025 13:53
@github-actions github-actions bot added the WIP work in progress label Jan 24, 2025
@github-actions github-actions bot added the dbt: daily covers the Daily dbt subproject label Jan 24, 2025
@github-actions github-actions bot added the dbt: tokens covers the Tokens dbt subproject label Jan 27, 2025
@jeff-dude
Copy link
Member

source data for sophon is still being finalized. can't query erc20 transfers yet, which we'll use to help initiate metadata spells here.

select *
from erc20_sophon.evt_transfer
limit 10

@jeff-dude jeff-dude self-assigned this Jan 29, 2025
@jeff-dude jeff-dude removed the blocked label Feb 16, 2025
@jeff-dude
Copy link
Member

removing the blocked tag, as i think we are able to continue here now. from initial query, looks like this is part of ZK stack similar to abstract chain. plz refer to my changes and comments in the abstract tokens transfers PR for reference and how to continue here.

@Hosuke Hosuke marked this pull request as ready for review February 17, 2025 14:06
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Feb 17, 2025
@Hosuke
Copy link
Collaborator Author

Hosuke commented Feb 17, 2025

removing the blocked tag, as i think we are able to continue here now. from initial query, looks like this is part of ZK stack similar to abstract chain. plz refer to my changes and comments in the abstract tokens transfers PR for reference and how to continue here.

I have implemented sophon.transfers using the zk stack template.

The CI error is about duped erc20 address under sonic chain:
https://dune.com/queries/4735628

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, this chain officially has me confused 😅
i think we can proceed as-is for now, then revisit trusted tokens / prices / whatever else as we build more on top later

@jeff-dude jeff-dude changed the title Initiate sophon chain DUX-839 Initiate sophon chain Feb 17, 2025
@jeff-dude
Copy link
Member

tokens transfers is returning 0 rows:
https://github.com/duneanalytics/spellbook/actions/runs/13374544897/job/37353562901?pr=7541#step:12:32

looks like majority of base_transfers are for the SOPH native token, which we don't have a price feed for yet. i think that's why they filter out. should we at least have rows returned for the one token in trusted tokens list for final transfers?

@jeff-dude jeff-dude added question Further information is requested in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Feb 17, 2025
@jeff-dude jeff-dude removed the question Further information is requested label Feb 19, 2025
@jeff-dude
Copy link
Member

similar to feedback on apechain, i think we should remove transfers spells from these initial PRs. the dependency on evms.info (inner join in macro) causes issues in initial builds. we will do:

  • metadata PR
  • transfers PR
  • DEX PR

@Hosuke
Copy link
Collaborator Author

Hosuke commented Feb 21, 2025

This PR should be ready to go.

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Feb 21, 2025
@jeff-dude jeff-dude merged commit 4589a35 into duneanalytics:main Feb 21, 2025
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: daily covers the Daily dbt subproject dbt: tokens covers the Tokens dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants