-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding shadow to dex.trades on sonic #7584
Conversation
dbt_subprojects/dex/models/trades/sonic/dex_sonic_base_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/seeds/trades/shadow_sonic_base_trades_seed.csv
Outdated
Show resolved
Hide resolved
Co-authored-by: Huang Geyang <[email protected]>
Co-authored-by: Huang Geyang <[email protected]>
….csv Co-authored-by: Huang Geyang <[email protected]>
It's been so long since I've github'd. Bare with me. I think I accidentally just re-requested you to review something for now reason. |
dbt_subprojects/dex/models/trades/sonic/platforms/shadow_sonic_base_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/models/trades/sonic/platforms/shadow_sonic_base_trades.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/dex/seeds/trades/shadow_sonic_base_trades_seed.csv
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that should have done it.
If shadow is newly added into dex.trades, then we may need to add it into dex.info as well: |
dbt_subprojects/dex/seeds/trades/shadow_sonic_base_trades_seed.csv
Outdated
Show resolved
Hide resolved
This, i *think*, should fix it. I kept flipping the bought and sold addresses some how.
smh, whenever I would query the check dex test schema, it looked like I had the bought and sold addresses swapped, so I flipped them: using the following as my seed: blockchain,project,version,block_date,tx_hash,evt_index,token_bought_address,token_sold_address,block_number,token_bought_amount_raw,token_sold_amount_raw sonic,shadow,3,2025-02-06,0x7d39202a1e950e05a9005648a3577b6306a1640b9a53ed3db8711bafaf02be03,4,0x039e2fb66102314ce7b64ce5ce3e5183bc94ad38,0x29219dd400f2bf60e5a23d13be72b486d4038894,6758314,250436493,538400000000000000000 I'm sure I'm missing something simple/obvious: Any chance @Hosuke could take a peek at it, and see if I'm making some obvious mistake? |
We need to update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.✅
Thank you @discochuck
Well, crap. Honestly, I accidentally pushed this PR to the spellbook when I meant to push it to my fork.
Sorry if it's a cluster f.
Description:
[...]
quick links for more information: