Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shadow to dex.trades on sonic #7584

Merged
merged 20 commits into from
Feb 17, 2025

Conversation

discochuck
Copy link
Contributor

@discochuck discochuck commented Jan 28, 2025

Well, crap. Honestly, I accidentally pushed this PR to the spellbook when I meant to push it to my fork.

Sorry if it's a cluster f.

Description:

[...]


quick links for more information:

@github-actions github-actions bot marked this pull request as draft January 28, 2025 13:36
@github-actions github-actions bot added WIP work in progress dbt: dex covers the DEX dbt subproject labels Jan 28, 2025
@discochuck discochuck marked this pull request as ready for review January 28, 2025 13:36
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 28, 2025
@Hosuke Hosuke self-assigned this Jan 28, 2025
@discochuck discochuck requested a review from Hosuke January 28, 2025 14:04
@discochuck
Copy link
Contributor Author

It's been so long since I've github'd. Bare with me. I think I accidentally just re-requested you to review something for now reason.

@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Jan 28, 2025
@jeff-dude jeff-dude marked this pull request as draft January 28, 2025 15:07
@github-actions github-actions bot added the WIP work in progress label Jan 28, 2025
Copy link
Contributor Author

@discochuck discochuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should have done it.

@Hosuke
Copy link
Collaborator

Hosuke commented Feb 1, 2025

If shadow is newly added into dex.trades, then we may need to add it into dex.info as well:
https://github.com/duneanalytics/spellbook/blob/main/dbt_subprojects/dex/models/dex_info.sql

@discochuck
Copy link
Contributor Author

discochuck commented Feb 6, 2025

smh, whenever I would query the check dex test schema, it looked like I had the bought and sold addresses swapped, so I flipped them:
image

image

using the following as my seed:
--snip
blockchain, sonic
project, shadow
version, 3
block_date, 2025-02-06
tx_hash, 0x7d39202a1e950e05a9005648a3577b6306a1640b9a53ed3db8711bafaf02be03
evt_index, 4
token_bought_address, 0x039e2fb66102314ce7b64ce5ce3e5183bc94ad38
token_sold_address, 0x29219dd400f2bf60e5a23d13be72b486d4038894
block_number, 6758314
token_bought_amount_raw, 250436493
token_sold_amount_raw 538400000000000000000

blockchain,project,version,block_date,tx_hash,evt_index,token_bought_address,token_sold_address,block_number,token_bought_amount_raw,token_sold_amount_raw

sonic,shadow,3,2025-02-06,0x7d39202a1e950e05a9005648a3577b6306a1640b9a53ed3db8711bafaf02be03,4,0x039e2fb66102314ce7b64ce5ce3e5183bc94ad38,0x29219dd400f2bf60e5a23d13be72b486d4038894,6758314,250436493,538400000000000000000
--snip

I'm sure I'm missing something simple/obvious: Any chance @Hosuke could take a peek at it, and see if I'm making some obvious mistake?

@Hosuke
Copy link
Collaborator

Hosuke commented Feb 6, 2025

@discochuck discochuck marked this pull request as ready for review February 7, 2025 06:29
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Feb 7, 2025
Copy link
Collaborator

@Hosuke Hosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hosuke Hosuke added ready-for-merging and removed ready-for-review this PR development is complete, please review in review Assignee is currently reviewing the PR labels Feb 7, 2025
@jeff-dude jeff-dude assigned jeff-dude and unassigned Hosuke Feb 16, 2025
@jeff-dude jeff-dude merged commit aebed1f into duneanalytics:main Feb 17, 2025
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: dex covers the DEX dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants