Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding sonic tokens #7607

Merged
merged 12 commits into from
Feb 17, 2025
Merged

Adding sonic tokens #7607

merged 12 commits into from
Feb 17, 2025

Conversation

Bruno12221
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@github-actions github-actions bot marked this pull request as draft January 31, 2025 09:02
@github-actions github-actions bot added WIP work in progress dbt: tokens covers the Tokens dbt subproject labels Jan 31, 2025
@Bruno12221 Bruno12221 marked this pull request as ready for review January 31, 2025 12:45
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 31, 2025
@jeff-dude jeff-dude closed this Feb 3, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2025
@jeff-dude jeff-dude reopened this Feb 3, 2025
@jeff-dude jeff-dude self-assigned this Feb 3, 2025
@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-review this PR development is complete, please review labels Feb 3, 2025
change wstkscUSD token_id
update stksceth-staked-sonic-eth token_id
used token_id `usdc-usd-coin` for stkscUSD and wstkscUSD
used token_id `sts-staked-sonic` for asS and wanS
used token_id `ws-wrapped-sonic` for OS and wOS
used token_id `sceth-sonic-eth` for wstkscETH
Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you're fine tying these addresses to those price feeds, then it'll work fine from the pipeline perspective

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Feb 4, 2025
Bruno12221 and others added 3 commits February 5, 2025 13:43
anS -> use sonic price
remove wanS
OS -> use sonic price
remove woS
add entry for sS, use sonic price
@Bruno12221 Bruno12221 requested a review from Hosuke February 17, 2025 10:40
@jeff-dude jeff-dude merged commit 49ff477 into duneanalytics:main Feb 17, 2025
3 of 4 checks passed
@@ -50,12 +50,19 @@ FROM (VALUES
, (0xD31E89Ffb929b38bA60D1c7dBeB68c7712EAAb0a, 'bSolvBTC-13', 18)
, (0x7870ddFd5ACA4E977B2287e9A212bcbe8FC4135a, 'BeefySiloV2USDC.e', 6)
, (0xe51ee9868c1f0d6cd968a8b8c8376dc2991bfe44, 'BRUSH', 18)
, (0x9fb76f7ce5FCeAA2C42887ff441D46095E494206, 'wstkscUSD', 6)
, (0x0C4E186Eae8aCAA7F7de1315D5AD174BE39Ec987, 'anS', 18)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that it didn't fail prod 🤔
i wonder if the token is in automated source, so it's ignored in manual here. let me dig in a bit and see what i can do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: tokens covers the Tokens dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants