fix: clarify order the directive #162
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161 and #92
Extends the default ordering to what FrankenPHP had before php/frankenphp#832.I suggest a more correct location for the
vulcain
directive — afterencode
.The current location (before
request_header
), I guess, was chosen for more correct request processing (to interact with unmodified request headers). I cannot judge the necessity of this.The proposed location (after
encode
) should solve the response encoding error. This location was also chosen to avoid re-processing of Link headers by thepush
directive.Expected change in the directive location
See Caddy's default directive order