Skip to content

Conversation

bynect
Copy link
Contributor

@bynect bynect commented Sep 3, 2024

Should resolve the issues pointed by @zappolowski in #1373

@bynect bynect requested a review from zappolowski September 3, 2024 09:05
@bynect
Copy link
Contributor Author

bynect commented Sep 3, 2024

@apprehensions is this solution ok for you?

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.37%. Comparing base (d2faa87) to head (9655f2c).
⚠️ Report is 176 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1376      +/-   ##
==========================================
+ Coverage   65.34%   65.37%   +0.02%     
==========================================
  Files          50       50              
  Lines        8326     8321       -5     
  Branches     1001      999       -2     
==========================================
- Hits         5441     5440       -1     
+ Misses       2885     2881       -4     
Flag Coverage Δ
unittests 65.37% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bynect bynect merged commit e7ddf50 into dunst-project:master Sep 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants