Skip to content

Conversation

bynect
Copy link
Member

@bynect bynect commented Oct 31, 2024

Addresses #1386

@bynect bynect requested a review from zappolowski October 31, 2024 21:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.14%. Comparing base (9d3c91a) to head (3fb71a6).
⚠️ Report is 168 commits behind head on master.

Files with missing lines Patch % Lines
src/dbus.c 0.00% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1389      +/-   ##
==========================================
+ Coverage   65.11%   65.14%   +0.02%     
==========================================
  Files          50       50              
  Lines        8649     8652       +3     
  Branches     1021     1022       +1     
==========================================
+ Hits         5632     5636       +4     
+ Misses       3017     3016       -1     
Flag Coverage Δ
unittests 65.14% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bynect bynect linked an issue Oct 31, 2024 that may be closed by this pull request
@bynect
Copy link
Member Author

bynect commented Oct 31, 2024

I also updated the wiki

behehei fix

Co-authored-by: Benedikt Heine <[email protected]>
@bynect
Copy link
Member Author

bynect commented Nov 11, 2024

@bebehei do you think this can be merged?

@bebehei
Copy link
Member

bebehei commented Nov 12, 2024

I don't see any problems. But I'm not confident anymore using "not seeing any problems" as a good indicator for having good code in this project.

@bynect bynect merged commit 56989b6 into dunst-project:master Nov 28, 2024
21 checks passed
@bynect
Copy link
Member Author

bynect commented Nov 28, 2024

I don't see any problems. But I'm not confident anymore using "not seeing any problems" as a good indicator for having good code in this project.

I'll just think of this as a LGTM moment then 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dunstctl history does not work
3 participants