Conversation
Add Makefile with standard targets (test, clippy, fmt, check, doc, clean, test-no-std, no-std). Add rustfmt.toml with nightly options (group_imports and imports_granularity disabled to avoid reformatting upstream zkcrypto code). Replace shared CI test workflows with inline make targets on core runners.
moCello
force-pushed
the
mocello/ai-friendliness
branch
4 times, most recently
from
e4ccebe to
52037e8
Compare
moCello
requested review from
HDauven,
Neotamandua,
d-sonuga,
fed-franz,
herr-seppia,
miloszm and
xevisalle
xevisalle
approved these changes
Mar 18, 2026
|
|
||
| BLS12-381 pairing-friendly elliptic curve implementation. **Fork of | ||
| zkcrypto/bls12_381** with Dusk-specific enhancements (multiscalar | ||
| multiplication, serde, rkyv, hash-to-scalar, bitwise ops). ~16.5k LOC. |
Member
There was a problem hiding this comment.
Isnt' LOC something that we will have to remember to update each time we increase it?
Member
There was a problem hiding this comment.
Well nvm, I guess it'll be done automatically since the whole file will need to be updated if things change.
Member
Author
There was a problem hiding this comment.
you are right, it's redundant and agents can figure out the line count easily by themselves. I'll remove 👍
The ordering is a consistent total order suitable for data structures like BTreeSet, but has no relationship to the mathematical value of the scalar since Montgomery representation permutes the field.
The subtle crate removed the into_option method from CtOption. Use Option::from() which is the supported conversion path.
moCello
force-pushed
the
mocello/ai-friendliness
branch
from
52037e8 to
6182368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also: