Implements #31 - Generators available as extended#34
Merged
Conversation
Every in-memory operation is performed with extended points, so the user of the API will always need to convert the Affine Points to extend before performing the operations. To facilitate, we made available by default the generators also in extended form.
CPerezz
suggested changes
Aug 13, 2020
CPerezz
left a comment
CPerezz
left a comment
There was a problem hiding this comment.
We should include tests that prove that the point is indeed a valid generator.
See tests for the other generator structures.
| #![no_std] | ||
| // Catch documentation errors caused by code changes. | ||
| #![deny(intra_doc_link_resolution_failure)] | ||
| #![deny(broken_intra_doc_links)] |
There was a problem hiding this comment.
GH actions doesn't seem to understant that lint. It's fine if it works anyway
Author
There was a problem hiding this comment.
They renamed this recently to broken_intra_doc_links
With a updated nightly you should receive a warning/error if using intra_doc_link_resolution_failure
Author
There was a problem hiding this comment.
added 2 commits
August 13, 2020 10:47
The extended generator was added to eliminate the need to convert to and from affine coordinates in each programme. The tests for this generator are added in this commit.
A lint error occured due to spacing. This is fixed in this commit.
These have just been added |
This was referenced Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every in-memory operation is performed with extended points, so the user
of the API will always need to convert the Affine Points to extend
before performing the operations.
To facilitate, we made available by default the generators also in
extended form.