Skip to content

Remove iter.rev #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
herr-seppia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove iter.rev #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Remove `iter.rev()` from BinaryID verification [#139]

## [0.6.1] - 2024-04-10

### Added
Expand Down Expand Up @@ -141,6 +145,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#135]: https://github.com/dusk-network/kadcast/issues/135
[#136]: https://github.com/dusk-network/kadcast/issues/136
[#138]: https://github.com/dusk-network/kadcast/issues/138
[#139]: https://github.com/dusk-network/kadcast/issues/139

<!-- Releases -->

Expand Down
4 changes: 2 additions & 2 deletions src/kbucket/key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ impl BinaryID {
let nonce_bytes = nonce.to_le_bytes();
hasher.update(nonce_bytes);
if BinaryID::verify_difficulty(
&mut hasher.finalize_reset().iter().rev(),
&mut hasher.finalize_reset().iter(),
K_DIFF_PRODUCED_BIT,
) {
return Self {
Expand All @@ -139,7 +139,7 @@ impl BinaryID {
hasher.update(self.bytes);
hasher.update(self.nonce);
BinaryID::verify_difficulty(
&mut hasher.finalize().iter().rev(),
&mut hasher.finalize().iter(),
K_DIFF_MIN_BIT,
)
}
Expand Down