Conversation
autholykos
reviewed
Apr 3, 2024
Member
autholykos
left a comment
autholykos
left a comment
There was a problem hiding this comment.
I think that making a reserved field dynamic is an anti-pattern. If the intention is to provide forward compatibility in the form of protocol extension, this should be properly introduced in the protocol without abusing the reserved field
Member
|
On a second thought, the impact of a dynamic |
herr-seppia
force-pushed
the
fix-reserved
branch
2 times, most recently
from
b3ae3c1 to
dedc023
Compare
herr-seppia
force-pushed
the
fix-reserved
branch
from
dedc023 to
9f96864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #137