Skip to content

transport: fix wording in a pair of log messages#158

Open
hughsw wants to merge 1 commit intodusk-network:mainfrom
hughsw:transport-warn-message
Open

transport: fix wording in a pair of log messages#158
hughsw wants to merge 1 commit intodusk-network:mainfrom
hughsw:transport-warn-message

Conversation

@hughsw
Copy link

@hughsw hughsw commented Jan 8, 2025

I got a novel-for-me pair of messages on a mainnet node:

{"timestamp":"2025-01-08T13:04:19.589942Z","level":"WARN","message":"Unable to send msg, temptative 1/3 - TIMEOUT","target":"kadcast::transport::sockets"}
{"timestamp":"2025-01-08T13:04:19.596117Z","level":"INFO","message":"Message sent, recovered from previous error","target":"kadcast::transport::sockets"}

I thought "temptative" might have some important semantic, but after looking at the code and digging into the etymology I learned that "temptative" is a Middle-English word, obsolete for hundreds of years, so I decided its appearance in the code is a misspelling. I fixed that, and I adjusted the wording of the two messages so that a more unified pair will appear in the log, e.g.

{"timestamp":"2025-01-08T13:04:19.589942Z","level":"WARN","message":"Send msg failure, attempt 1 of 3, TIMEOUT, ","target":"kadcast::transport::sockets"}
{"timestamp":"2025-01-08T13:04:19.596117Z","level":"INFO","message":"Send msg success, attempt 2","target":"kadcast::transport::sockets"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant