transport: fix wording in a pair of log messages#158
Open
hughsw wants to merge 1 commit intodusk-network:mainfrom
Open
transport: fix wording in a pair of log messages#158hughsw wants to merge 1 commit intodusk-network:mainfrom
hughsw wants to merge 1 commit intodusk-network:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got a novel-for-me pair of messages on a mainnet node:
I thought "temptative" might have some important semantic, but after looking at the code and digging into the etymology I learned that "temptative" is a Middle-English word, obsolete for hundreds of years, so I decided its appearance in the code is a misspelling. I fixed that, and I adjusted the wording of the two messages so that a more unified pair will appear in the log, e.g.