Skip to content

Set MSRV 1.85 & use stable toolchain#100

Merged
HDauven merged 2 commits intomainfrom
move-to-stable
Feb 2, 2026
Merged

Set MSRV 1.85 & use stable toolchain#100
HDauven merged 2 commits intomainfrom
move-to-stable

Conversation

@HDauven
Copy link
Member

@HDauven HDauven commented Jan 24, 2026

No description provided.

@HDauven HDauven requested a review from Copilot January 24, 2026 15:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the project to use Rust's stable toolchain and sets the Minimum Supported Rust Version (MSRV) to 1.85. The changes align with Rust 1.85's stabilization of elided lifetimes in associated constant contexts, eliminating the need for a nightly toolchain.

Changes:

  • Updated toolchain from nightly-2023-11-10 to stable
  • Set MSRV to 1.85 in Cargo.toml files
  • Updated lifetime elision syntax to use explicit '_ lifetimes
  • Removed nightly toolchain requirement from documentation

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rust-toolchain.toml Changed toolchain channel from nightly to stable
dusk-merkle/Cargo.toml Added rust-version = "1.85"
poseidon-merkle/Cargo.toml Added rust-version = "1.85"
dusk-merkle/src/node.rs Updated lifetime elision to explicit '_
dusk-merkle/src/tree.rs Updated lifetime elision to explicit '_ in three functions
dusk-merkle/src/walk.rs Simplified match expression to if-let statement
dusk-merkle/README.md Removed nightly toolchain requirement note
rustfmt.toml Removed wrap_comments configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HDauven
Copy link
Member Author

HDauven commented Jan 25, 2026

@HDauven HDauven requested a review from moCello February 2, 2026 09:26
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HDauven HDauven merged commit 61ef6ee into main Feb 2, 2026
5 checks passed
@HDauven HDauven deleted the move-to-stable branch February 2, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants