Repository navigation
Prepare version 0.24.0 - #1013
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The release metadata is consistent with the stated version, date, and comparison base.
0 open findings
What changed in this PR
Prepares the dusk-plonk 0.24.0 release.
Changes:
- Bumps the crate version to 0.24.0.
- Promotes Unreleased notes and updates comparison links.
| File | Description |
|---|---|
Cargo.toml |
Updates the package version. |
CHANGELOG.md |
Publishes release notes and comparison links. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## deps/bls-0.16-jubjub-0.16 #1013 +/- ##
=============================================================
- Coverage 92.27% 92.25% -0.03%
=============================================================
Files 81 81
Lines 8886 8909 +23
=============================================================
+ Hits 8200 8219 +19
- Misses 686 690 +4
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
moCello
left a comment
There was a problem hiding this comment.
COMMENT — The version, the release header and the comparison links are consistent with each other and with v0.22.1 as the base. One change before approval:
append_logic_component_layout_matches_golden(src/composer/tests/soundness/logic.rs) andcomponent_mul_generator_layout_matches_golden(src/composer/tests/soundness/fixed_base.rs) still call their digests a drift pin of unreleased gates. 0.24.0 ships those gates, so from this release a changed digest means a changed verifier key for every caller, such as thedusk-poseidonhash gadget. The notes tell a maintainer the opposite: that a golden is free to re-capture. In this commit, delete the release-status sentences ("drift pin", "unreleased", "becomes a compatibility pin then") from the doc comments and the capture comments of both tests. Keep only what the digests pin, so the text does not go stale at the next release.
aaf75f2 to
ee9c93a
Compare
|
Force-pushed
|
moCello
left a comment
There was a problem hiding this comment.
APPROVE — The version, the release header, the yanked 0.23.0 entry and the comparison links agree with each other and with v0.22.1 as the base, and the golden-test notes no longer depend on the release status.
- The pull request description says the change touches only
Cargo.tomlandCHANGELOG.md, but the head commit also edits the notes of two tests insrc/composer/tests/soundness/. Update the description.
ee9c93a to
1b70b78
Compare
|
Force-pushed |
Summary
Prepare dusk-plonk 0.24.0. Stacked on #1012.
src/composer/tests/soundness/: from 0.24.0, a changed digest changes the verifier key of every circuit that uses the gadget.