Skip to content

Prepare version 0.24.0 - #1013

Merged
HDauven merged 1 commit into
deps/bls-0.16-jubjub-0.16from
release/0.24.0
Oct 8, 2026
Merged

HDauven merged 1 commit into
deps/bls-0.16-jubjub-0.16from
release/0.24.0

Conversation

@HDauven

@HDauven HDauven commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Summary

Prepare dusk-plonk 0.24.0. Stacked on #1012.

  • Bump the version, promote the pending changelog and update the comparison links.
  • The version is 0.24.0, not 0.23.0: 0.23.0 was published and then yanked, so its number cannot be reused. The changelog records it as yanked, and the comparison base is v0.22.1.
  • Drop the release-status notes from the two golden tests in src/composer/tests/soundness/: from 0.24.0, a changed digest changes the verifier key of every circuit that uses the gadget.

@HDauven
HDauven added this pull request to stack #1014 October 8, 2026 08:51
@HDauven
HDauven requested a balanced review from Copilot October 8, 2026 08:51

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The release metadata is consistent with the stated version, date, and comparison base.

0 open findings

What changed in this PR

Prepares the dusk-plonk 0.24.0 release.

Changes:

  • Bumps the crate version to 0.24.0.
  • Promotes Unreleased notes and updates comparison links.
File Description
Cargo.toml Updates the package version.
CHANGELOG.md Publishes release notes and comparison links.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (a634f1f) to head (1b70b78).

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                      @@
##           deps/bls-0.16-jubjub-0.16    #1013      +/-   ##
=============================================================
- Coverage                      92.27%   92.25%   -0.03%     
=============================================================
  Files                             81       81              
  Lines                           8886     8909      +23     
=============================================================
+ Hits                            8200     8219      +19     
- Misses                           686      690       +4     
Files with missing lines Coverage Δ
src/composer/tests/soundness/fixed_base.rs 85.16% <ø> (ø)
src/composer/tests/soundness/logic.rs 94.79% <ø> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a634f1f...1b70b78. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HDauven
HDauven marked this pull request as ready for review October 8, 2026 09:02

@moCello moCello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMMENT — The version, the release header and the comparison links are consistent with each other and with v0.22.1 as the base. One change before approval:

  • append_logic_component_layout_matches_golden (src/composer/tests/soundness/logic.rs) and component_mul_generator_layout_matches_golden (src/composer/tests/soundness/fixed_base.rs) still call their digests a drift pin of unreleased gates. 0.24.0 ships those gates, so from this release a changed digest means a changed verifier key for every caller, such as the dusk-poseidon hash gadget. The notes tell a maintainer the opposite: that a golden is free to re-capture. In this commit, delete the release-status sentences ("drift pin", "unreleased", "becomes a compatibility pin then") from the doc comments and the capture comments of both tests. Keep only what the digests pin, so the text does not go stale at the next release.

Comment thread CHANGELOG.md
@HDauven

HDauven commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

Force-pushed ee9c93a6, rebased onto the updated #1012:

  • The two golden tests no longer carry release-status notes. Each doc now says that a changed digest changes the verifier key of every circuit that calls the gadget, and the capture comments say only what the digests cover.
  • The yanked 0.23.0 entry is in (see the thread on CHANGELOG.md).

@HDauven
HDauven requested a review from moCello October 8, 2026 10:14

@moCello moCello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — The version, the release header, the yanked 0.23.0 entry and the comparison links agree with each other and with v0.22.1 as the base, and the golden-test notes no longer depend on the release status.

  • The pull request description says the change touches only Cargo.toml and CHANGELOG.md, but the head commit also edits the notes of two tests in src/composer/tests/soundness/. Update the description.

@HDauven

HDauven commented Oct 8, 2026

Copy link
Copy Markdown
Member Author

Force-pushed 1b70b78b, rebased onto the updated #1012 (test comments only). The description now lists the golden-test notes and the yanked 0.23.0 entry.

@HDauven
HDauven merged commit b932820 into master Oct 8, 2026
13 checks passed
@HDauven
HDauven deleted the release/0.24.0 branch October 8, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants