wallet-core: add eip2334 deterministic account hierarchy derivation support#3660
Open
Neotamandua wants to merge 6 commits intomasterfrom
Open
wallet-core: add eip2334 deterministic account hierarchy derivation support#3660Neotamandua wants to merge 6 commits intomasterfrom
Neotamandua wants to merge 6 commits intomasterfrom
Conversation
Neotamandua
force-pushed
the
neotamandua/3572
branch
from
662293a to
cf43dfe
Compare
- Re-export legacy module to keep same interface for now - Make eip2334 public
Neotamandua
force-pushed
the
neotamandua/3572
branch
from
cf43dfe to
2c998be
Compare
- Fix clippy lints
Neotamandua
force-pushed
the
neotamandua/3572
branch
from
3f63b1e to
97caa62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds EIP2334 support to wallet-core as well as a migration tx function for transferring funds from a legacy Moonlight account to the corresponding EIP-2333 derived account based on the same seed
Before adopting this approach for specific wallets going forward, the related issue of incorporating HD support for phoenix keys should be considered, as outlined here: #3684