forked from NCAR/fv3atm
-
Notifications
You must be signed in to change notification settings - Fork 0
JUST FOR DISCUSSION #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dustinswales
wants to merge
49
commits into
NOAA-EMC-develop
Choose a base branch
from
feature/ccpp_framework_update
base: NOAA-EMC-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e44d0d2.
…ture/ccpp_framework_update
…ture/ccpp_framework_update
…on (NOAA-EMC#994) * Add destination mask for regional history output grids * Replace 'zeroregion' with 'zeroregionflag' in ESMF_FieldBundleSMM call
…ture/ccpp_framework_update
* Reorganize code for MPAS dycore. Isolate FV3 and MPAS pieces. * Added more build step pieces, up until the MPAS dycore build * MPAS building in UFSATM! Some more reorganization. Initial infrastructure for CCPP. More CMake modifications * Move ccpp/drivers into common directory (revert prioir move) * Move MPAS to ufs-community reporitory * Update CMakeLists in MPAS core.
…ture/ccpp_framework_update
…AA-EMC#993) * GFS_typedefs.F90 and GFS_typedefs.meta are updated to include TTE-EDMF, which can be used in combination with sa3dtke and use_lpt.
…Sv13/SFSv1 (NOAA-EMC#1002) * Introduce tuning parameter for convective cloud liquid
* Replaces the current integer option of icplocn2atm with a logical flag use_oceanuv * Current UFS RT which utilizes the ocean surface currents in the ATM is B4B with this change
point to updated ccpp-physics
* Modify calculation of bucket average radiation variables to be accurate at sub-radiation-timestep output frequency. * Update bucket radiation scaling for rad_swlw_min variables * Bug fix in rad_lwsw_min scaling parameter. Merge GFS_rrtmg/rrtmgp_post.F90 in to GFS_radiation_post.F90 in ccpp/physics, requiring changes to all suites. * Add SW clear-sky downward flux at surface to available diagnostics * fix compilation error in GFS_diagnostics.F90 * update atmos_cubed_sphere to turn ENABLE_PARALLELRESTART OFF by default to avoid RT errors on some platforms (Hera, Hercules at least) * ccpp-physics - wet() bug fix and workaround for bad tsfco * update CCPP SDFs to replace GFS_rrtmg_post with GFS_radiation_post * change GFS_rrtmg_post in MPAS-based suite * fix MPAS-based ccpp_prebuild config that still referenced GFS_rrtmgX_post --------- Co-authored-by: Larissa Reames <[email protected]> Co-authored-by: Dustin Swales <[email protected]> Co-authored-by: Samuel Trahan <samuel,[email protected]>
* Update rte-rrtmgp submodule hash to v1.8 and add any necessary CCPP interface changes. * Changes to use single precision in rte-rrtmgp CCPP interface * Updated GP enabled SDF to v17_p8. Removed unused options in GFS_typedefs.F90 * Fix MPI types in broadcast calls --------- Co-authored-by: Grant Firl <[email protected]>
* make some Thompson MP tuning parameters externally visible * update ccpp/physics pointer * add some missing metadata for Thompson parameters * update submodule pointer * update ccpp/physics
* Update upp hash to 4a5d595f
There is a low cloud bias in the current version of the GFSv17. The formula used in the cloud cover calculation is based Xu/Randall (1996). To increase the cloud cover in the GFSv17, a different set of parameters is used in the formulation. The increase in the cloud cover will also help to reduce the downward SW at the surface.
…d radiative fluxes, etc (NOAA-EMC#1032) * revert the change made to the accumulated fields including to the average cloud covers and radiative fluxes
* Fix explicit declaration compiler warnings * Re-add dropped Set IAU offset time in fv3/module_fcst_grid_comp.F90 * use post_nems_routines in tests/test_post_nems_routines.F90
…ned reset routine (NOAA-EMC#1004) * Bug fix in GFS_typedefs.meta: horizontal_loop_extent --> horizontal_dimension * For GFS_interstitial DDT, replace phys_reset and rad_reset with one overall reset routine * Revert default values for all GFS_interstitial DDT members to previous values
…MC#997) * Add 'file_version' global attribute to sfc_data restart files * Fix compiler warnings. cpld_debug_gfsv17 passes on ursa * Update upp hash * use post_nems_routines_mod in tests/test_post_nems_routines.F90 --------- Co-authored-by: Nick Szapiro <[email protected]>
dustinswales
pushed a commit
that referenced
this pull request
Jan 14, 2026
* Update diagnose_cplFields routine to use FieldBundleWrite. Needs esmf v8.6.0 * Fixed bug in aux2d dimensions for GFS meta file. * Pass return code from diagnose_cplFields back to caller * Skip 'cpl_scalars' field when dumping export state * fix fhzero for GEFS * fix cpl_scalars (#6) * fix issues w/ cplscalars * error out of all 3 spatial indices are not present * add check for scalar_id = 0 * modify for timeslices and times (#7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FV3atm changes associated with ccpp-framework update NCAR/ccpp-framework#668