Fixed bug where background was incorrectly reset given multiple strings #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in
cudaFonts.cu:479
that causes incorrect backgrounds to be drawn when multiple strings are given tocudaFont::OverlayText
. The current rectangle frommRectsCPU
is not correctly indexed. Instead, always the first rectangle inmRectsCPU
is indexed and reset. Incrementing withnumRects
fixes this issue.Code to make the issue more clear:
Two images showing the result before and after the fix:
before
after