FIX dsa: wwwl from srcImage#440
Closed
laura-borghesi-lum00n wants to merge 5 commits intomasterfrom
Closed
Conversation
daron1337
requested changes
Apr 1, 2025
Member
daron1337
left a comment
There was a problem hiding this comment.
Manca anche la descrizione della Pull Request
Contributor
🧪 TypeScript Coverage ReportTotal Coverage: 📄 File Coverage Details
|
Contributor
🧪 TypeScript Coverage ReportTotal Coverage: 📄 File Coverage Details
|
Contributor
🧪 TypeScript Coverage ReportTotal Coverage: 📄 File Coverage Details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the window width (windowWidth) and window center (windowCenter) of images created with DSA-applied masks are correctly initialized by default to match those of the original image (srcImage).
Key Changes & Behavior:
If the original image (srcImage) has defined windowCenter and windowWidth, those values are used for the newly created image.
If windowCenter (middle of the computed range) or windowWidth (based on the pixel intensity range) are missing in the original image, fallback values are computed based on pixel intensity: