Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the binary and bitstring types #277

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Support the binary and bitstring types #277

merged 1 commit into from
Aug 9, 2019

Conversation

yuezato
Copy link
Collaborator

@yuezato yuezato commented Aug 7, 2019

Deal with the issue #126

@yuezato
Copy link
Collaborator Author

yuezato commented Aug 7, 2019 •
edited
Loading

On this PR, we distinguish <<_:M, _:_*N>> and <<_:M', _:_*N'>> if M ≠ M' or N ≠ N'.

Although inf(binary = <<0, 8>>, bitstring = <<0, 1>>) = bottom at this time, Dialyzer does not behave as our implementation. Dialyzer allows this test: https://github.com/dwango/fialyzer/pull/277/files#diff-6be91df8b829c1b8c34687e31486dbff

Obeying Dialyzer is the next step task.

yoshihiro503
yoshihiro503 approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@yoshihiro503 yoshihiro503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuezato
Copy link
Collaborator Author

yuezato commented Aug 9, 2019

Related to this issue: #281

@yuezato yuezato merged commit 3ccb1b4 into dwango:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshihiro503 yoshihiro503 yoshihiro503 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuezato @yoshihiro503