Tmp/tokio 1.0 #28
Draft
Tmp/tokio 1.0 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brly
reviewed
Feb 5, 2021
| let flag = Arc::new(AtomicBool::new(false)); | ||
| let flag_cp = flag.clone(); | ||
| let fut_listen_03 = async move { | ||
| let listener = tokio::net::TcpListener::bind(addr).await.unwrap(); |
There was a problem hiding this comment.
このファイルが提供している struct とかをテストしてるわけじゃなさそうなんですけど, このテストはここにあったほうが良いのでしょうか？
There was a problem hiding this comment.
確かにそうなのですが、他に適切な置き場所もなく、という感じです。
brly
reviewed
Feb 5, 2021
| let mut future = futures::failed::<(), ()>(()).timeout_after(Duration::from_secs(1)); | ||
| assert_eq!(future.poll(), Err(Some(()))); | ||
| let mut exec = ThreadPoolExecutor::new().unwrap(); | ||
| // 直接 timeout を呼ぶと動かず、and_then の中で呼ぶと動く。 |
There was a problem hiding this comment.
確かにそのようです.
thread 'time::timer::test::it_works' panicked at 'there is no reactor running, must be called from the context of a Tokio 1.x runtime', /home/tmiyashita/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-1.1.1/src/runtime/context.rs:37:26
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Ok(Async::Ready()) が戻るのが分かったり出来たら良かったんですけど, 難しそうですね
shinnya
reviewed
Mar 17, 2021
| } | ||
|
|
||
| /// Runs infinitely until an error happens. | ||
| fn run(self) -> io::Result<()> { |
There was a problem hiding this comment.
サポートできないなら fibers-rs のメジャーバージョンを変更し、このメソッドも API から削除してしまってはどうでしょう。
There was a problem hiding this comment.
そうします。よく考えたらいずれにせよ、io, net, fiber::schedule モジュールは消してしまうので、メジャーバージョンの更新は必須でした。
|
lib.rs から mod io, mod net, mod fiber::schedule を削除し、利用者が io, net, fiber::schedule を利用できないようにしました。(io と net は fibers 経由で利用させることができないため、fiber::schedule は tokio のスケジューラと競合するため) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.